Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#36 support sheet format version2 #43

Merged
merged 3 commits into from
Oct 3, 2022
Merged

#36 support sheet format version2 #43

merged 3 commits into from
Oct 3, 2022

Conversation

ma91n
Copy link
Contributor

@ma91n ma91n commented Oct 1, 2022

Ticket

#36

Description

  • 3行目に version 2.0 と記述すると、exceltesting sheet format v2 として判定し、5行目から物理名を記載できる。

Checked list

>go test
PASS
ok      github.com/future-architect/go-exceltesting     1.317s

Related PRs

none

Screen captures

load_v2.xlsx

image

@ma91n ma91n added the enhancement New feature or request label Oct 1, 2022
@d-tsuji
Copy link
Collaborator

d-tsuji commented Oct 1, 2022

内容自体はLGTMです！
マージする際にCIがPASSするか確認いただけると助かります

ちなみに LoadWithContext (Load) だけでなく CompareWithContext(Compare) も将来的に対応予定でしょうか？

@d-tsuji d-tsuji self-requested a review October 2, 2022 02:00
@future-mano
Copy link
Contributor

@d-tsuji

ちなみに LoadWithContext (Load) だけでなく CompareWithContext(Compare) も将来的に対応予定でしょうか？

修正した、
https://github.com/future-architect/go-exceltesting/pull/43/files#diff-ea2dc75675d2aa520f4725de8336af9262fd6b4ee640ecbd49abc831afbbc938R293

ですが、これはLoadWithContext , CompareWithContextの両方から呼ばれるので、同時に対応した次第です。
Compare側のテストにも、v2のシートを追加しました。

@d-tsuji d-tsuji merged commit fdb4418 into main Oct 3, 2022
@d-tsuji d-tsuji deleted the feature/#37_format_v2 branch October 3, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-tsuji d-tsuji d-tsuji approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ma91n @d-tsuji @future-mano